Unlock the private 'kebabCase' function at a file level #60755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
Mamaduka
requested review from
tellthemachines,
ellatrix and
ajitbohra
as code owners
Mamaduka
requested review from
tyxla and
t-hamano
and removed request for
ajitbohra,
ellatrix and
tellthemachines
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -45 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ee2f801. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8693754569
|
t-hamano
reviewed
Apr 16, 2024
From my understanding, there should be no good reason for this to happen. I actually have a clue what the problem might be. Taking a look and will reply shortly. |
|
Okay, found the culprit. It appears that we have circular dependencies in the native app. Currently, the However, you can see that we import modules from That's wrong, of course, since the former isn't a dependency of the latter. To verify my hypothesis, I ran Resolving this will need some reshuffling of native components here and there, so there are no circular dependencies. A similar fix was done by @ellatrix in #57045. I'm quite occupied with other things this week, and won't be able to take a look, so feel free to work on this one @Mamaduka @t-hamano. Thanks 🙌 |
|
FWIW resolving this will allow us to do single-module unlocks for all other instances we're doing it on runtime for mobile - there are a few more, for example: |
|
Thank you, @tyxla! I had the feeling that there was something wrong with the config, but circular dependencies didn't cross my mind. Happy to pick it up from here 🙇 |
|
Yes I started looking at fixing the circular dependency but didn't finish it, I also have a PR open for this at #57042 |
|
Thank you, @geriux! I started looking into it, but I've very little experience with RN. I wasn't even able to build the app locally :( |
No worries! I worked on some of those files so that helped a bit! Let us know if the future if we can help with getting the app to build locally 😃 |
|
Hey everyone 👋 the mobile team just merged #61102 which should solve the blockers in this PR. Please let us know if there are still blockers that we might have missed. Thank you! |
|
@tyxla, I'll rebase and make sure everything is up to date later today. |
Mamaduka
force-pushed
the
update/kebabcase-unlock-method
branch
from
ee2f801
to
aa19eca
Compare
t-hamano
approved these changes
May 19, 2024
Mamaduka
force-pushed
the
update/kebabcase-unlock-method
branch
from
aa19eca
to
30c38cd
Compare
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org> Co-authored-by: geriux <geriux@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #56758.
PR moves the private
kebabCasefunction unlocking at the file level.Why?
Private APIs like functions can be unlocked at the file level, avoiding executing unlocking logic multiple times.
Testing Instructions
CI checks should be green.